Fixes for test collection and guards for missing PhysicsNeMo-Sym #902
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ript file collection using pathlib to fix collection errors.
…equired, but currently is)
…sicsnemo into psharpe/test_collection
|
/blossom-ci |
|
/blossom-ci |
ktangsali
reviewed
Jul 13, 2025
| @@ -70,11 +70,14 @@ class MdlsUNetMetaData(ModelMetaData): | |||
| # [physicsnemo model] | |||
|
|
|||
| # [physicsnemo sym model] | |||
|
|
|||
There was a problem hiding this comment.
When does this failure occur? The code snippet here is rendered in the docs, and the try-except will not look good. For running pytest in the root directory, make pytest should be preferred. I can see the rationale of supporting pytest . too, but unforutnately this does not work in the present setting. Maybe something like below is better to modify the default behavior of pytest (reference):
[tool.pytest.ini_options]
testpaths = ["test"]
or perhaps a .pytest.ini file
|
/blossom-ci |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PhysicsNeMo Pull Request
Description
Addresses two bugs:
pytest .from root caused an error in test collection due to path issues intest_runner.py. Fixed this, and refactored to use the more-modernpathlibbuiltin library instead ofos.path. (In general, going forward, we should typically preferpathliboveros.path)This provides a fix for the first bug, and at least a more graceful failure for the second bug.
Checklist
Dependencies